Thread: Regression test fails with postgresql*-test package

Hi,

When I try to run a regression test, it fails as follows:

----
$ cd /usr/pgsql-14/lib/test/regress
$ make
rm -rf testtablespace results
mkdir testtablespace results
[ -x /usr/bin/chcon ] && /usr/bin/chcon -u system_u -r object_r -t postgresql_db_t testtablespace results
./pg_regress --inputdir=. --psqldir='/usr/bin'   --dlpath=. --schedule=./parallel_schedule
./pg_regress: unrecognized option '--psqldir=/usr/bin'

Try "pg_regress -h" for more information.
make: *** [installcheck-parallel] Error 2
----

The --psqldir option has been changed to the --bindir option. Also,
serial_schedule has been removed.

I made a patch, so I will attach it. 

Best regards,


----
Tomoaki Sato <sato@sraoss.co.jp>
SRA OSS, Inc. Japan
--- Makefile.orig    2021-10-11 00:46:16.923423035 +0900
+++ Makefile    2021-10-11 00:46:46.457904583 +0900
@@ -21,7 +21,7 @@
 
 pg_regress_locale_flags = $(if $(ENCODING),--encoding=$(ENCODING)) $(NOLOCALE)
 
-pg_regress_installcheck = ./pg_regress --inputdir=$(srcdir) --psqldir='/usr/bin' $(pg_regress_locale_flags)
+pg_regress_installcheck = ./pg_regress --inputdir=$(srcdir) --bindir='/usr/bin' $(pg_regress_locale_flags)
 
 # Test input and expected files.  These are created by pg_regress itself, so we
 # don't have a rule to create them.  We do need rules to clean them however.
@@ -36,7 +36,7 @@
 check: installcheck-parallel
 
 installcheck: cleandirs
-    $(pg_regress_installcheck) $(REGRESS_OPTS) --schedule=$(srcdir)/serial_schedule $(EXTRA_TESTS)
+    $(pg_regress_installcheck) $(REGRESS_OPTS) --schedule=$(srcdir)/parallel_schedule --max-connections=1
$(EXTRA_TESTS)
 
 installcheck-parallel: cleandirs
     $(pg_regress_installcheck) $(REGRESS_OPTS) --schedule=$(srcdir)/parallel_schedule $(MAXCONNOPT) $(EXTRA_TESTS)

Hi,

On Mon, 2021-10-11 at 01:11 +0900, Tomoaki Sato wrote:
> When I try to run a regression test, it fails as follows:
>
> ----
> $ cd /usr/pgsql-14/lib/test/regress
> $ make
> rm -rf testtablespace results
> mkdir testtablespace results
> [ -x /usr/bin/chcon ] && /usr/bin/chcon -u system_u -r object_r -t
> postgresql_db_t testtablespace results
> ./pg_regress --inputdir=. --psqldir='/usr/bin'   --dlpath=. --
> schedule=./parallel_schedule
> ./pg_regress: unrecognized option '--psqldir=/usr/bin'
>
> Try "pg_regress -h" for more information.
> make: *** [installcheck-parallel] Error 2
> ----
>
> The --psqldir option has been changed to the --bindir option. Also,
> serial_schedule has been removed.

Apparently you are the first person to run RPM provided regression
tests at least since v10 :-) Thanks for the report. Committed patch (I
also merged a change in Fedora's makefile) to all supported versions.

> I made a patch, so I will attach it.

Thanks. This change will appear in next month's minor release updates.

Regards,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR