Thread: Improved tab completion for PostgreSQL parameters in enums
Hi If you do tab completion in a situation like A, you will see ["on"] instead of [on]. A : "ALTER SYSTEM SET wal_compression TO " I made a patch for this problem. regards, Kosei Masumura
Attachment
On Wed, Oct 06, 2021 at 02:24:40PM +0900, bt21masumurak wrote: > If you do tab completion in a situation like A, you will see ["on"] instead > of [on]. > > A : "ALTER SYSTEM SET wal_compression TO " > > I made a patch for this problem. This would break the completion of enum entries that require quotes to work properly for some of their values, like default_transaction_isolation. -- Michael
Attachment
bt21masumurak <bt21masumurak@oss.nttdata.com> writes: > If you do tab completion in a situation like A, you will see ["on"] > instead of [on]. > A : "ALTER SYSTEM SET wal_compression TO " > I made a patch for this problem. I do not think this is an improvement. It will result in omitting quotes in some cases where they're not optional. Try it with a value such as "all", for example. regards, tom lane
Thank you for comments. > I do not think this is an improvement. It will result in omitting > quotes in some cases where they're not optional. Try it with a > value such as "all", for example. > This would break the completion of enum entries that require quotes to > work properly for some of their values, like > default_transaction_isolation. I understand these comments, and the proposal was withdrawn. Regards, Kosei Masumura 2021-10-06 23:34 に Tom Lane さんは書きました: > bt21masumurak <bt21masumurak@oss.nttdata.com> writes: >> If you do tab completion in a situation like A, you will see ["on"] >> instead of [on]. > >> A : "ALTER SYSTEM SET wal_compression TO " > >> I made a patch for this problem. > > I do not think this is an improvement. It will result in omitting > quotes in some cases where they're not optional. Try it with a > value such as "all", for example. > > regards, tom lane