Re: Improved tab completion for PostgreSQL parameters in enums - Mailing list pgsql-hackers

From bt21masumurak
Subject Re: Improved tab completion for PostgreSQL parameters in enums
Date
Msg-id e74c67183846d05064f634eec94f77e4@oss.nttdata.com
Whole thread Raw
In response to Re: Improved tab completion for PostgreSQL parameters in enums  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Thank you for comments.

> I do not think this is an improvement.  It will result in omitting
> quotes in some cases where they're not optional.  Try it with a
> value such as "all", for example.

> This would break the completion of enum entries that require quotes to
> work properly for some of their values, like
> default_transaction_isolation.

I understand these comments, and the proposal was withdrawn.

Regards,
Kosei Masumura

2021-10-06 23:34 に Tom Lane さんは書きました:
> bt21masumurak <bt21masumurak@oss.nttdata.com> writes:
>> If you do tab completion in a situation like A, you will see ["on"]
>> instead of [on].
> 
>> A : "ALTER SYSTEM SET wal_compression TO "
> 
>> I made a patch for this problem.
> 
> I do not think this is an improvement.  It will result in omitting
> quotes in some cases where they're not optional.  Try it with a
> value such as "all", for example.
> 
>             regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: prevent immature WAL streaming
Next
From: Andres Freund
Date:
Subject: Re: prevent immature WAL streaming