Thread: Recent cpluspluscheck failures

On HEAD, I see these headers failing to compile standalone:

$ src/tools/pginclude/cpluspluscheck
In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
./src/include/common/unicode_east_asian_fw_table.h:3:32: error: elements of array 'const mbinterval east_asian_fw []'
haveincomplete type 
 static const struct mbinterval east_asian_fw[] = {
                                ^~~~~~~~~~~~~
./src/include/common/unicode_east_asian_fw_table.h:3:32: error: storage size of 'east_asian_fw' isn't known
In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
./src/include/replication/worker_internal.h:60:2: error: 'FileSet' does not name a type
  FileSet    *stream_fileset;
  ^~~~~~~

The first of these is evidently the fault of bab982161 (Update display
widths as part of updating Unicode), which introduced that header.
The second seems to have been introduced by 31c389d8d (Optimize fileset
usage in apply worker).

Please fix.

            regards, tom lane

John Naylor <john.naylor@enterprisedb.com> writes:
> On Thu, Sep 23, 2021 at 2:37 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> On HEAD, I see these headers failing to compile standalone:
>> $ src/tools/pginclude/cpluspluscheck
>> In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
>> ./src/include/common/unicode_east_asian_fw_table.h:3:32: error: elements
> of array 'const mbinterval east_asian_fw []' have incomplete type

> Okay, this file is used similarly to
> src/include/common/unicode_combining_table.h, which has an exception in the
> check script, so I'll add another exception.

OK, but see also src/tools/pginclude/headerscheck.

            regards, tom lane