Recent cpluspluscheck failures - Mailing list pgsql-hackers

From Tom Lane
Subject Recent cpluspluscheck failures
Date
Msg-id 2324798.1632422270@sss.pgh.pa.us
Whole thread Raw
Responses Re: Recent cpluspluscheck failures  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers
On HEAD, I see these headers failing to compile standalone:

$ src/tools/pginclude/cpluspluscheck
In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
./src/include/common/unicode_east_asian_fw_table.h:3:32: error: elements of array 'const mbinterval east_asian_fw []'
haveincomplete type 
 static const struct mbinterval east_asian_fw[] = {
                                ^~~~~~~~~~~~~
./src/include/common/unicode_east_asian_fw_table.h:3:32: error: storage size of 'east_asian_fw' isn't known
In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
./src/include/replication/worker_internal.h:60:2: error: 'FileSet' does not name a type
  FileSet    *stream_fileset;
  ^~~~~~~

The first of these is evidently the fault of bab982161 (Update display
widths as part of updating Unicode), which introduced that header.
The second seems to have been introduced by 31c389d8d (Optimize fileset
usage in apply worker).

Please fix.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Next
From: Daniel Gustafsson
Date:
Subject: Re: OpenSSL 3.0.0 compatibility