Postgres Pro
Downloads
Home   >   mailing lists

Thread: Feature #6395 - Basic Log Rotation

Feature #6395 - Basic Log Rotation

From
Thomas Greenwood
Date:

Hi,

I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.

Please find the attached basic patch as a starter for 10. It's the same patch attached to the feature issue.

Thanks a lot,

Tom

Attachment

Re: Feature #6395 - Basic Log Rotation

From
COG Internet
Date:
Hi,

I have a version 2 of this with a fixed conditional and initial config values which I'll send through later today.

Thanks,

Tom

On 19 April 2021 17:17:30 Thomas Greenwood <tom@coginternet.net> wrote:

Hi,

I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.

Please find the attached basic patch as a starter for 10. It's the same patch attached to the feature issue.

Thanks a lot,

Tom


Re: Feature #6395 - Basic Log Rotation

From
Dave Page
Date:
Hi

On Mon, Apr 19, 2021 at 5:17 PM Thomas Greenwood <tom@coginternet.net> wrote:

Hi,

I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.

Please find the attached basic patch as a starter for 10. It's the same patch attached to the feature issue.


Nice! My only suggestions would be that the config options be added to config.py, with default values of zero for log size, and say, 5 for the number of backups (should that be 'archives'?), and that we test to see if the log size is > 0 before enabling rotation. The reason for that is that we keep all config options in config.py to ensure it's self-documenting.

--

Re: Feature #6395 - Basic Log Rotation

From
Akshay Joshi
Date:
Hi Tom

On Tue, Apr 20, 2021 at 3:56 PM COG Internet <tom@coginternet.net> wrote:
Hi,

I have a version 2 of this with a fixed conditional and initial config values which I'll send through later today.

    Have you worked on this? If patch is ready can you please send it.  

Thanks,

Tom

On 19 April 2021 17:17:30 Thomas Greenwood <tom@coginternet.net> wrote:

Hi,

I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.

Please find the attached basic patch as a starter for 10. It's the same patch attached to the feature issue.

Thanks a lot,

Tom




--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246