Thread: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the

pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the

From
Akshay Joshi
Date:
Use 'sys.executable' to get the absolute path of the executable binary for the Python interpreter instead of existing
complexlogic. 

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d612c5

Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 89 +--------------------------------
1 file changed, 1 insertion(+), 88 deletions(-)


Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the

From
Murtuza Zabuawala
Date:
Hi,

It will break the WSGI.

--
Regards,
Murtuza Zabuawala
EDB
POWER TO POSTGRES


On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Use 'sys.executable' to get the absolute path of the executable binary for the Python interpreter instead of existing complex logic.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d612c5

Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 89 +--------------------------------
1 file changed, 1 insertion(+), 88 deletions(-)

Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the

From
Akshay Joshi
Date:
Hi Murtuza/Hackers

On Tue, Feb 9, 2021 at 4:51 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

It will break the WSGI.

   I have tested pgAdmin4 using the following combination:
   I have made the code changes after installation, use sys.executable, and then restart the apache in both the above test scenario. All the utilities(Backup, Maintainance, etc...) working absolutely fine. Please refer to the below screenshot

           pgAdmin_APT.png

   Am I missing some scenario? If any specific test scenario that I missed please let me know so that I'll figure out some solution.
 

--
Regards,
Murtuza Zabuawala
EDB
POWER TO POSTGRES


On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Use 'sys.executable' to get the absolute path of the executable binary for the Python interpreter instead of existing complex logic.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d612c5

Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 89 +--------------------------------
1 file changed, 1 insertion(+), 88 deletions(-)



--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment

Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the

From
Murtuza Zabuawala
Date:
Hi,


On Tue, Feb 9, 2021 at 7:37 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Murtuza/Hackers

On Tue, Feb 9, 2021 at 4:51 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

It will break the WSGI.

   I have tested pgAdmin4 using the following combination:
   I have made the code changes after installation, use sys.executable, and then restart the apache in both the above test scenario. All the utilities(Backup, Maintainance, etc...) working absolutely fine. Please refer to the below screenshot

           pgAdmin_APT.png

   Am I missing some scenario? If any specific test scenario that I missed please let me know so that I'll figure out some solution.

I don't remember the exact scenario/steps but AFAIR we rewrote that logic to handle scenario when we run pgAdmin4 under WSGI and/or on Windows, It was using the wrong python path to execute the process executor.
-- Murtuza
 

--
Regards,
Murtuza Zabuawala
EDB
POWER TO POSTGRES


On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Use 'sys.executable' to get the absolute path of the executable binary for the Python interpreter instead of existing complex logic.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d612c5

Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 89 +--------------------------------
1 file changed, 1 insertion(+), 88 deletions(-)



--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Attachment