Thread: Re: Document "59.2. Built-in Operator Classes" have a clerical error?

Re: Document "59.2. Built-in Operator Classes" have a clerical error?

From
Alvaro Herrera
Date:
On 2020-Aug-27, Michael Paquier wrote:

> This leads me to the updated version attached.  BRIN has 29 different
> opclasses, visibly.

I checked both HTML and PDF and it looks good to me to commit.

As a subsequent improvement we could discuss tweak the stylesheets to
change the column widths in PDF, but I don't think we need to stall this
patch for that, since it's a much smaller issue IMV.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: Document "59.2. Built-in Operator Classes" have a clerical error?

From
Tom Lane
Date:
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Aug-27, Michael Paquier wrote:
>> This leads me to the updated version attached.  BRIN has 29 different
>> opclasses, visibly.

> I checked both HTML and PDF and it looks good to me to commit.

I did not verify that the correct operators are listed, but visually
it looks OK.

One thing I've noted in working with this stuff is that (at least for me)
HTML seems to default to valign=center while PDF defaults to valign=top.
You can see that in these tables in the positioning of the opclass names.
For myself, valign=center looks better in these cases so I'd suggest
adding <colspec>s to force it that way.  Or, if you like valign=top,
we should do that --- but it ought to be consistent across output formats.

> As a subsequent improvement we could discuss tweak the stylesheets to
> change the column widths in PDF, but I don't think we need to stall this
> patch for that, since it's a much smaller issue IMV.

Yeah, I think some fooling with the column widths could improve the PDF
results, but it's a minor point.

            regards, tom lane