Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin][SonarQube] Cognitive complexity roles + test cases

[pgAdmin][SonarQube] Cognitive complexity roles + test cases

From
Aditya Toshniwal
Date:
Hi Hackers,

Attached is the patch to reduce the cognitive complexity for validate_request function in roles module from 258 to 15. I've also added a few more test scenarios in the roles RE-SQL test cases to make sure the changes are tested.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][SonarQube] Cognitive complexity roles + test cases

From
Akshay Joshi
Date:
Thanks, patch applied.

On Thu, Aug 27, 2020 at 12:49 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to reduce the cognitive complexity for validate_request function in roles module from 258 to 15. I've also added a few more test scenarios in the roles RE-SQL test cases to make sure the changes are tested.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246