Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] Cognitive complexity roles + test cases - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][SonarQube] Cognitive complexity roles + test cases
Date
Msg-id CANxoLDdc5Z0ZzszSUNZbNUE=K6FOKPXU8bugvpWc97wAZu7igQ@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][SonarQube] Cognitive complexity roles + test cases  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Thu, Aug 27, 2020 at 12:49 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to reduce the cognitive complexity for validate_request function in roles module from 258 to 15. I've also added a few more test scenarios in the roles RE-SQL test cases to make sure the changes are tested.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed an issue where the application ignores the fixe
Next
From: Akshay Joshi
Date:
Subject: Re: [PATCH] Fix pgAdmin4 v4.25 ignoring user configuration. Fixes #5773