Thread: Editing errors in the comments of tableam.h and heapam.c

Hi,

Some comments in tableam.h and heapam.c contain three old function names 
although these have been renamed by this commit 
73b8c3bd2889fed986044e15aefd0911f96ccdd3.

Old: table_insert, table_fetch_row_version, table_get_latest_tid.

New: table_tuple_insert, table_tuple_fetch_row_version, 
table_tuple_get_latest_tid.

I think these are editing errors. PG 12 also has the same errors.


Best regards,

On Mon, Jul 13, 2020 at 02:25:39PM +0200, Hironobu SUZUKI wrote:
> Some comments in tableam.h and heapam.c contain three old function names
> although these have been renamed by this commit
> 73b8c3bd2889fed986044e15aefd0911f96ccdd3.
>
> Old: table_insert, table_fetch_row_version, table_get_latest_tid.
>
> New: table_tuple_insert, table_tuple_fetch_row_version,
> table_tuple_get_latest_tid.

Thanks.  That looks right.

> I think these are editing errors. PG 12 also has the same errors.

Yeah.  We also recommend to look at tableam.h in the docs, so while
usually I just bother fixing comments on HEAD, it would be better to
back-patch this one.
--
Michael

On Mon, Jul 13, 2020 at 09:52:12PM +0900, Michael Paquier wrote:
> Yeah.  We also recommend to look at tableam.h in the docs, so while
> usually I just bother fixing comments on HEAD, it would be better to
> back-patch this one.

Committed and back-patched down to 12.  Thanks, Suzuki-san.
--
Michael