Postgres Pro
Downloads
Home   >   mailing lists

Re: Editing errors in the comments of tableam.h and heapam.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Editing errors in the comments of tableam.h and heapam.c
Date
Msg-id 20200713125212.GC10826@paquier.xyz
Whole thread Raw
In response to Editing errors in the comments of tableam.h and heapam.c  (Hironobu SUZUKI <hironobu@interdb.jp>)
Responses Re: Editing errors in the comments of tableam.h and heapam.c
List pgsql-hackers
Tree view 
On Mon, Jul 13, 2020 at 02:25:39PM +0200, Hironobu SUZUKI wrote:
> Some comments in tableam.h and heapam.c contain three old function names
> although these have been renamed by this commit
> 73b8c3bd2889fed986044e15aefd0911f96ccdd3.
>
> Old: table_insert, table_fetch_row_version, table_get_latest_tid.
>
> New: table_tuple_insert, table_tuple_fetch_row_version,
> table_tuple_get_latest_tid.

Thanks.  That looks right.

> I think these are editing errors. PG 12 also has the same errors.

Yeah.  We also recommend to look at tableam.h in the docs, so while
usually I just bother fixing comments on HEAD, it would be better to
back-patch this one.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: output columns of \dAo and \dAp
Next
From: Dave Cramer
Date:
Subject: Re: Binary support for pgoutput plugin