Petr Jelinek <petr@2ndquadrant.com> writes: > On 11/07/2020 14:14, Dave Cramer wrote: >> So is there any point in having them as options then ?
> I am guessing this is copied from pglogical, right? We have them there > because it can optionally send data in the on-disk format (not the > network binary format) and there this matters, but for network binary > format they do not matter as Tom says.
Ah, I wondered why that was there at all. Yes, you should just delete all that logic --- it's irrelevant as long as we use the send/recv functions.
regards, tom lane
Ok,
removed all the unnecessary options.
Added the test case that Daniel had created.
Added a note to the docs.
Note WAL_DEBUG is removed in patch 3. I could rebase that into patch 1 if required.
