Thread: [pgAdmin][SonarQube] Critical issue fixes - servers

[pgAdmin][SonarQube] Critical issue fixes - servers

From
Rahul Shirsat
Date:
Hi Hackers,

Please find the attached patch which includes sonarqube fixes :

1. Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed
    for check_ssl_fields in servers/__init__.py
2. Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed
    for update in servers/__init__.py

Note: Changes were tested in both Server mode & Desktop mode respectively.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.
Attachment

Re: [pgAdmin][SonarQube] Critical issue fixes - servers

From
Rahul Shirsat
Date:
Hi Hackers,

Please find the updated patch below which fixes the issue in sslcompression changes.

On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which includes sonarqube fixes :

1. Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed
    for check_ssl_fields in servers/__init__.py
2. Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed
    for update in servers/__init__.py

Note: Changes were tested in both Server mode & Desktop mode respectively.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.
Attachment

Re: [pgAdmin][SonarQube] Critical issue fixes - servers

From
Akshay Joshi
Date:
Thanks, patch applied.

On Thu, Jul 9, 2020 at 7:15 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the updated patch below which fixes the issue in sslcompression changes.

On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which includes sonarqube fixes :

1. Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed
    for check_ssl_fields in servers/__init__.py
2. Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed
    for update in servers/__init__.py

Note: Changes were tested in both Server mode & Desktop mode respectively.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246