Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] Critical issue fixes - servers - Mailing list pgadmin-hackers

From Rahul Shirsat
Subject Re: [pgAdmin][SonarQube] Critical issue fixes - servers
Date
Msg-id CAKtn9dP8cv6ss5zjjsHTWkVkmeWDbWsK3PFNRW9BEH7TZW_ijA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][SonarQube] Critical issue fixes - servers  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
Responses Re: [pgAdmin][SonarQube] Critical issue fixes - servers  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Hackers,

Please find the updated patch below which fixes the issue in sslcompression changes.

On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which includes sonarqube fixes :

1. Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed
    for check_ssl_fields in servers/__init__.py
2. Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed
    for update in servers/__init__.py

Note: Changes were tested in both Server mode & Desktop mode respectively.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed)
Next
From: Nikhil Mohite
Date:
Subject: [pgAdmin][RM5329][Code Coverage] Improve API test cases for FTS Configuration, FTS Dictionary, FTS Parser, FTS Template