Thread: pgsql: pg_waldump: Add a --quiet option.
pg_waldump: Add a --quiet option. The primary motivation for this change is that it will be used by the upcoming patch to add backup manifests, but it also seems to have some potential more general use. Andres Freund and Robert Haas Discussion: http://postgr.es/m/20200330020814.nspra4mvby42yoa4@alap3.anarazel.de Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ac44367efbef198c57a18b96dbc6a39191720994 Modified Files -------------- doc/src/sgml/ref/pg_waldump.sgml | 12 ++++++++++++ src/bin/pg_waldump/pg_waldump.c | 22 ++++++++++++++++------ 2 files changed, 28 insertions(+), 6 deletions(-)
On 2020/04/03 10:11, Robert Haas wrote:
> pg_waldump: Add a --quiet option.
>
> The primary motivation for this change is that it will be used by the
> upcoming patch to add backup manifests, but it also seems to have some
> potential more general use.
I'm not sure what the actual purpose of this feature yet, but ISTM that
the following change is necessary. Otherwise, "empty" stats information
is output even when --quiet is specified.
- if (config.stats == true)
+ if (config.stats == true && !config.quiet)
XLogDumpDisplayStats(&config, &stats);
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On Thu, Apr 2, 2020 at 9:41 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote: > On 2020/04/03 10:11, Robert Haas wrote: > > pg_waldump: Add a --quiet option. > > > > The primary motivation for this change is that it will be used by the > > upcoming patch to add backup manifests, but it also seems to have some > > potential more general use. > > I'm not sure what the actual purpose of this feature yet, but ISTM that > the following change is necessary. Otherwise, "empty" stats information > is output even when --quiet is specified. > > - if (config.stats == true) > + if (config.stats == true && !config.quiet) > XLogDumpDisplayStats(&config, &stats); Oops. That seems like a bug. It only matters if you specify --quiet and --stats together, but even so the behavior is not as documented, so it should be fixed. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company