Re: pgsql: pg_waldump: Add a --quiet option. - Mailing list pgsql-committers

On Thu, Apr 2, 2020 at 9:41 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> On 2020/04/03 10:11, Robert Haas wrote:
> > pg_waldump: Add a --quiet option.
> >
> > The primary motivation for this change is that it will be used by the
> > upcoming patch to add backup manifests, but it also seems to have some
> > potential more general use.
>
> I'm not sure what the actual purpose of this feature yet, but ISTM that
> the following change is necessary. Otherwise, "empty" stats information
> is output even when --quiet is specified.
>
> -       if (config.stats == true)
> +       if (config.stats == true && !config.quiet)
>                  XLogDumpDisplayStats(&config, &stats);

Oops. That seems like a bug. It only matters if you specify --quiet
and --stats together, but even so the behavior is not as documented,
so it should be fixed. Thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company