Postgres Pro
Downloads
Home   >   mailing lists

Thread: To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, but thesyntax error when you run.

To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, but thesyntax error when you run.

From
nuko yokohama
Date:
Hi.

I'm using the "Incremental Materialized View Maintenance" patch and have reported the following issues.
(https://commitfest.postgresql.org/25/2138/)

To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, but the syntax error when you run.
("DROP MATERIALIZED VIEW" command can drop Incremental Materialozed view normally.)


ramendb=# CREATE INCREMENTAL MATERIALIZED VIEW pref_count AS SELECT pref, COUNT(pref) FROM shops GROUP BY pref;
SELECT 48
ramendb=# \d pref_count
          Materialized view "public.pref_count"
    Column     |  Type  | Collation | Nullable | Default
---------------+--------+-----------+----------+---------
 pref          | text   |           |          |
 count         | bigint |           |          |
 __ivm_count__ | bigint |           |          |

ramendb=# DROP IN
INCREMENTAL MATERIALIZED VIEW  INDEX
ramendb=# DROP INCREMENTAL MATERIALIZED VIEW pref_count;
2019-11-27 11:51:03.916 UTC [9759] ERROR:  syntax error at or near "INCREMENTAL" at character 6
2019-11-27 11:51:03.916 UTC [9759] STATEMENT:  DROP INCREMENTAL MATERIALIZED VIEW pref_count;
ERROR:  syntax error at or near "INCREMENTAL"
LINE 1: DROP INCREMENTAL MATERIALIZED VIEW pref_count;
             ^
ramendb=# DROP MATERIALIZED VIEW pref_count ;
DROP MATERIALIZED VIEW
ramendb=#


Regard.

Re: To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, butthe syntax error when you run.

From
Michael Paquier
Date:
On Thu, Nov 28, 2019 at 01:00:05PM +0900, nuko yokohama wrote:
> To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, but the syntax
> error when you run.
> ("DROP MATERIALIZED VIEW" command can drop Incremental Materialozed view
> normally.)

It seems to me that this is just an issue with the tab completion the
patch is adding.  When reviewing the patch, could you just report such
issues directly on the thread of the patch?  Thanks!
--
Michael
Attachment

Re: To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, butthe syntax error when you run.

From
Yugo Nagata
Date:
Hello nuko-san, 

Thank you for your review!

As Michael commentted, we would like to discuss this on the thread
of the patch, so I quote your review in the following post.

https://www.postgresql.org/message-id/20191129154513.943f4ef05896d7b9d3fed69f%40sraoss.co.jp

Regards,
Yugo Nagata

On Thu, 28 Nov 2019 13:05:33 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> On Thu, Nov 28, 2019 at 01:00:05PM +0900, nuko yokohama wrote:
> > To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, but the syntax
> > error when you run.
> > ("DROP MATERIALIZED VIEW" command can drop Incremental Materialozed view
> > normally.)
> 
> It seems to me that this is just an issue with the tab completion the
> patch is adding.  When reviewing the patch, could you just report such
> issues directly on the thread of the patch?  Thanks!
> --
> Michael


-- 
Yugo Nagata <nagata@sraoss.co.jp>