Thread: obsolete example

Em qui., 21 de nov. de 2019 às 15:59, Pavel Stehule
<pavel.stehule@gmail.com> escreveu:
>
> isn't src/tutorial/func.c obsolete? There is not any benefit for users.
>
version-0 calling conventions were removed in v10. It seems an
oversight at commit 5ded4bd2140. Tutorial needs some care (I'm not
volunteering to improve it). I suggest unbreak the funcs module with
'mv funcs_new.c func.c'.


--
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

On Thu, Nov 21, 2019 at 08:19:56PM -0300, Euler Taveira wrote:
> Em qui., 21 de nov. de 2019 às 15:59, Pavel Stehule
> <pavel.stehule@gmail.com> escreveu:
>>
>> isn't src/tutorial/func.c obsolete? There is not any benefit for users.
>
> version-0 calling conventions were removed in v10. It seems an
> oversight at commit 5ded4bd2140. Tutorial needs some care (I'm not
> volunteering to improve it). I suggest unbreak the funcs module with
> 'mv funcs_new.c func.c'.

No objections from here, let's get rid of it.  The docs actually make
use of the V1 versions, and funcs_new.c is not even compiled (it does
compile).  Any objections to the attached?  On top of moving the file,
there is one comment to update and a sentence to remove.  Some
progress is always better than no progress.
--
Michael

Michael Paquier <michael@paquier.xyz> writes:
> No objections from here, let's get rid of it.  The docs actually make
> use of the V1 versions, and funcs_new.c is not even compiled (it does
> compile).  Any objections to the attached?  On top of moving the file,
> there is one comment to update and a sentence to remove.  Some
> progress is always better than no progress.

+1

            regards, tom lane

On Fri, Nov 22, 2019 at 06:11:32AM +0100, Pavel Stehule wrote:
> +1

Okay, done.  I have added a .gitignore while on it in the path for the
files generated.
--
Michael