Thread: Remove unused function argument
The cache_plan argument to ri_PlanCheck has not been used since e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it. That commit said "I left it alone in case there is any future need for it" but there hasn't been a need in 7 years, and I find it confusing to have an unused function argument without a clear purpose. It would trivial to put it back if needed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment
On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > > The cache_plan argument to ri_PlanCheck has not been used since > e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it. > > That commit said "I left it alone in case there is any future need for > it" but there hasn't been a need in 7 years, and I find it confusing to > have an unused function argument without a clear purpose. It would > trivial to put it back if needed. > Code changes looks fine to me. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
On 2019-10-30 06:51, vignesh C wrote: > On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut > <peter.eisentraut@2ndquadrant.com> wrote: >> >> The cache_plan argument to ri_PlanCheck has not been used since >> e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it. >> >> That commit said "I left it alone in case there is any future need for >> it" but there hasn't been a need in 7 years, and I find it confusing to >> have an unused function argument without a clear purpose. It would >> trivial to put it back if needed. >> > Code changes looks fine to me. pushed, thanks -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services