Re: Remove unused function argument - Mailing list pgsql-hackers

From vignesh C
Subject Re: Remove unused function argument
Date
Msg-id CALDaNm0O_OwOn7_mRcEw8UCoQ0ssoq2=00-=OMoUWeT+qb1FDg@mail.gmail.com
Whole thread Raw
In response to Remove unused function argument  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Remove unused function argument
List pgsql-hackers
On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
>
> The cache_plan argument to ri_PlanCheck has not been used since
> e8c9fd5fdf768323911f7088e8287f63b513c3c6.  I propose to remove it.
>
> That commit said "I left it alone in case there is any future need for
> it" but there hasn't been a need in 7 years, and I find it confusing to
> have an unused function argument without a clear purpose.  It would
> trivial to put it back if needed.
>
Code changes looks fine to me.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: "imai.yoshikazu@fujitsu.com"
Date:
Subject: RE: [Proposal] Add accumulated statistics
Next
From: "imai.yoshikazu@fujitsu.com"
Date:
Subject: RE: [Proposal] Add accumulated statistics