Thread: wrong Visual Studio Edition 's name
Hi all, I perhaps found mistake in postgresql doucment. In 'Installation from Source Code on Windows' chapter, 'Visual Studio Express 2019' is contained. But Visual Studio Express exists until only 2017, so Express Edition on 2019 don't exist. I think that we shoud fix it to 'Visual Studio 2019' or 'Visual Studio Community 2019'. Best Regards, -- Takuma Hoshiai <hoshiai@sraoss.co.jp>
On Tue, Aug 20, 2019 at 12:02:31PM +0900, Takuma Hoshiai wrote: > In 'Installation from Source Code on Windows' chapter, > 'Visual Studio Express 2019' is contained. > But Visual Studio Express exists until only 2017, so Express Edition > on 2019 does not exist. I think that we should fix it to 'Visual > Studio 2019' or 'Visual Studio Community 2019'. Okay, that sounds right. There are two places where we use this term. I would just take the most simple wording and use "Visual Studio 2019" for both. People would most likely understand what's behind it anyway, and big M pushes with this formulation as far as I understood. Perhaps others have thoughts to share? Hoshiai-san, would you like to send a patch? -- Michael
Attachment
On Tue, 20 Aug 2019 14:00:45 +0900 Michael Paquier <michael@paquier.xyz> wrote: > On Tue, Aug 20, 2019 at 12:02:31PM +0900, Takuma Hoshiai wrote: > > In 'Installation from Source Code on Windows' chapter, > > 'Visual Studio Express 2019' is contained. > > But Visual Studio Express exists until only 2017, so Express Edition > > on 2019 does not exist. I think that we should fix it to 'Visual > > Studio 2019' or 'Visual Studio Community 2019'. > > Okay, that sounds right. There are two places where we use this term. > I would just take the most simple wording and use "Visual Studio 2019" > for both. People would most likely understand what's behind it > anyway, and big M pushes with this formulation as far as I understood. I think so,too. "Visual Studio 2019" is good. > Perhaps others have thoughts to share? > > Hoshiai-san, would you like to send a patch? OK, I will send a patch to this thread,right? > -- > Michael -- Takuma Hoshiai <hoshiai@sraoss.co.jp>
On Tue, Aug 20, 2019 at 02:20:04PM +0900, Takuma Hoshiai wrote: > OK, I will send a patch to this thread,right? If you can send it here, that would be great. -- Michael
Attachment
On Tue, 20 Aug 2019 14:37:09 +0900 Michael Paquier <michael@paquier.xyz> wrote: > On Tue, Aug 20, 2019 at 02:20:04PM +0900, Takuma Hoshiai wrote: > > OK, I will send a patch to this thread,right? > > If you can send it here, that would be great. > -- > Michael I have attached a patch. The word of "Express" existed in four places, they will are fixed by this patch. Best Regards, -- Takuma Hoshiai <hoshiai@sraoss.co.jp>
Attachment
On Tue, Aug 20, 2019 at 03:38:28PM +0900, Takuma Hoshiai wrote: > I have attached a patch. The word of "Express" existed in four > places, they will are fixed by this patch. - These compilers can be either from <productname>Visual Studio</productname>, - <productname>Visual Studio Express</productname> or some versions of the - <productname>Microsoft Windows SDK</productname>. If you do not already have a - <productname>Visual Studio</productname> environment set up, the easiest - ways are to use the compilers from <productname>Visual Studio Express 2019 - for Windows Desktop</productname> or those in the <productname>Windows SDK + These compilers can be either from <productname>Visual Studio</productname> + or some versions of the <productname>Microsoft Windows SDK</productname>. + If you do not already have a <productname>Visual Studio</productname> + environment set up, the easiest ways are to use the compilers + from <productname>Visual Studio 2019</productname> + or those in the <productname>Windows SDK 10</productname>, which are both free downloads from Microsoft. I may be missing something, but this refers to all the possible flavors of VS where compilers are available, hence mentioning Visual Studio Express is still correct when going through our full supported range from VS 2013 to VS 2019, no? That's why I said only two places need to be fixed, as this area is fine. -- Michael
Attachment
On Tue, 20 Aug 2019 19:19:01 +0900 Michael Paquier <michael@paquier.xyz> wrote: > On Tue, Aug 20, 2019 at 03:38:28PM +0900, Takuma Hoshiai wrote: > > I have attached a patch. The word of "Express" existed in four > > places, they will are fixed by this patch. > > - These compilers can be either from <productname>Visual Studio</productname>, > - <productname>Visual Studio Express</productname> or some versions of the > - <productname>Microsoft Windows SDK</productname>. If you do not already have a > - <productname>Visual Studio</productname> environment set up, the easiest > - ways are to use the compilers from <productname>Visual Studio Express 2019 > - for Windows Desktop</productname> or those in the <productname>Windows SDK > + These compilers can be either from <productname>Visual Studio</productname> > + or some versions of the <productname>Microsoft Windows SDK</productname>. > + If you do not already have a <productname>Visual Studio</productname> > + environment set up, the easiest ways are to use the compilers > + from <productname>Visual Studio 2019</productname> > + or those in the <productname>Windows SDK > 10</productname>, which are both free downloads from Microsoft. > > I may be missing something, but this refers to all the possible > flavors of VS where compilers are available, hence mentioning Visual > Studio Express is still correct when going through our full supported > range from VS 2013 to VS 2019, no? That's why I said only two places > need to be fixed, as this area is fine. Yes, Express edition is contained by supported range. But my understanding is that other Edition are also same. The reason for changing above sentence, was that I thought that we don't need to specify Express edition only. The above original sentence is no problem too, so I have reattached a patch, which is fixed "Express 2019" only. > -- > Michael -- Takuma Hoshiai <hoshiai@sraoss.co.jp>
Attachment
On Wed, Aug 21, 2019 at 01:03:01PM +0900, Takuma Hoshiai wrote: > The above original sentence is no problem too, so I have reattached a patch, > which is fixed "Express 2019" only. Thanks, applied down to 9.4. I have been hesitating about a third place, and at the end included it in the set fixed. -- Michael