Thread: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for CheckConstraint node
[pgAdmin4][Patch] - RE-SQL and modified SQL tests for CheckConstraint node
From
Khushboo Vashi
Date:
Hi,
Please find the attached patch for the RE-SQL and modified SQL tests for check constraint node.
For the table child nodes, create table endpoint with proper data is required in the JSON file.
I have introduced one new parameter named store_table_id in the table create endpoint, so the created table ID will be stored for the rest of the scenarios.
Thanks,
Khushboo
Attachment
Hi
On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch for the RE-SQL and modified SQL tests for check constraint node.For the table child nodes, create table endpoint with proper data is required in the JSON file.I have introduced one new parameter named store_table_id in the table create endpoint, so the created table ID will be stored for the rest of the scenarios
This breaks the type tests :-(
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for CheckConstraint node
From
Khushboo Vashi
Date:
Hi Dave,
On Tue, Jul 16, 2019 at 2:05 PM Dave Page <dpage@pgadmin.org> wrote:
HiOn Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch for the RE-SQL and modified SQL tests for check constraint node.For the table child nodes, create table endpoint with proper data is required in the JSON file.I have introduced one new parameter named store_table_id in the table create endpoint, so the created table ID will be stored for the rest of the scenariosThis breaks the type tests :-(
Fixed.
Please find the attached updated patch.
Thanks,
Khushboo
--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks, patch applied.
On Tue, Jul 16, 2019 at 12:01 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,On Tue, Jul 16, 2019 at 2:05 PM Dave Page <dpage@pgadmin.org> wrote:HiOn Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch for the RE-SQL and modified SQL tests for check constraint node.For the table child nodes, create table endpoint with proper data is required in the JSON file.I have introduced one new parameter named store_table_id in the table create endpoint, so the created table ID will be stored for the rest of the scenariosThis breaks the type tests :-(Fixed.Please find the attached updated patch.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company