Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for CheckConstraint node - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for CheckConstraint node
Date
Msg-id CA+OCxoxnSk6fVehiuFHTHMVO6et9rRszaZHz6t+3q9LG70t+nA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for CheckConstraint node  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Tue, Jul 16, 2019 at 12:01 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

On Tue, Jul 16, 2019 at 2:05 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for the RE-SQL and modified SQL tests for check constraint node.

For the table child nodes, create table endpoint with proper data is required in the JSON file.
I have introduced one new parameter named store_table_id in the table create endpoint, so the created table ID will be stored for the rest of the scenarios

This breaks the type tests :-( 

Fixed.
Please find the attached updated patch. 

Thanks,
Khushboo
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Add Reverse Engineered SQL tests for Constraints. Fix
Next
From: Dave Page
Date:
Subject: Subtle test problem