Thread: [pgAdmin4][RM3575] Right click does not work on database node ifserver name changed

[pgAdmin4][RM3575] Right click does not work on database node ifserver name changed

From

Aditya Toshniwal

Date:

09 January 2019, 13:46:03

Hi Hackers,

Attached is the patch to fix the issue where changing the name (or any visible property on tree) of the server node breaks the context menu on the database nodes.

The user information of the server is updated on successful connection. Here, the data is updated on the aciTreeNode(domNode). But, in the context menu the user data is referred from TreeNode object (a wrapper to aciTreeNode). After checking the code (and a lot of debugging) it was found that aciTreeNode and TreeNode point to two different data(I don't know why). Every time you change one, it should be synced to other, which is not done everywhere.

Changes are done to point both aciTreeNode and TreeNode data to the same data object.

Kindly review.

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

Attachment

RM3575.patch

Re: [pgAdmin4][RM3575] Right click does not work on database node ifserver name changed

From

Dave Page

Date:

10 January 2019, 09:23:05

Thanks - patch applied.

On Wed, Jan 9, 2019 at 4:16 PM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix the issue where changing the name (or any visible property on tree) of the server node
breaksthe context menu on the database nodes. 
>
> The user information of the server is updated on successful connection. Here, the data is updated on the
aciTreeNode(domNode).But, in the context menu the user data is referred from TreeNode object (a wrapper to
aciTreeNode).After checking the code (and a lot of debugging) it was found that aciTreeNode and TreeNode point to two
differentdata(I don't know why). Every time you change one, it should be synced to other, which is not done everywhere. 
> Changes are done to point both aciTreeNode and TreeNode data to the same data object.
>
> Kindly review.
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company