Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][RM3575] Right click does not work on database node ifserver name changed - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject [pgAdmin4][RM3575] Right click does not work on database node ifserver name changed
Date
Msg-id CAM9w-_mBN5ZYxTZ2wcWuJ6RLvsffG+iha9Zb8bRJok=-cuNZ7w@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][RM3575] Right click does not work on database node ifserver name changed
List pgadmin-hackers
Tree view
Hi Hackers,

Attached is the patch to fix the issue where changing the name (or any visible property on tree) of the server node breaks the context menu on the database nodes.

The user information of the server is updated on successful connection. Here, the data is updated on the aciTreeNode(domNode). But, in the context menu the user data is referred from TreeNode object (a wrapper to aciTreeNode). After checking the code (and a lot of debugging) it was found that aciTreeNode and TreeNode point to two different data(I don't know why). Every time you change one, it should be synced to other, which is not done everywhere.
Changes are done to point both aciTreeNode and TreeNode data to the same data object.

Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayedin properties tab
Next
From: Aditya Toshniwal
Date:
Subject: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help