Thread: [pgAdmin4][Patch]: RM #3619 Unable to Re-Dock Query Tool Lower Window Component

Hi Hackers,

On Tue, Nov 27, 2018 at 5:27 PM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Nov 27, 2018 at 11:48 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Dave

On Tue, Nov 27, 2018 at 4:34 PM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Nov 27, 2018 at 10:13 AM Akshay Joshi
<akshay.joshi@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM #3619 Unable to Re-Dock Query Tool Lower Window Component. Please review it.

With this applied, I cannot move or resize floating windows.

    Attached is the modified patch. Please review it.  

That's better, but I am still able to un-dock the last panel, despite it looking like it tries to prevent me. See the attached movie. 

    We have figured out the actual cause of the problem, there is no title for the "SQL Editor" panel so when we undock lower window component then there is no title bar present to re-dock it. To fix the issue we have added the title for the "SQL Editor" panel and also move up the Query History tab. 

     Attached is the patch, please review it.      

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Hi Hackers,

Please ignore my previous patch, as I forgot to fix the same for "Debugger" module. I have fixed it with showing function name with argument as title of the Debugger panel. Please refer the attached screenshot. It provides the added advantage, if multiple debugger panel opens then it is easy to know which function we are debugging. 

Attached is the modified patch, please review it.

On Wed, Nov 28, 2018 at 4:35 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Hackers,

On Tue, Nov 27, 2018 at 5:27 PM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Nov 27, 2018 at 11:48 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Dave

On Tue, Nov 27, 2018 at 4:34 PM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Nov 27, 2018 at 10:13 AM Akshay Joshi
<akshay.joshi@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM #3619 Unable to Re-Dock Query Tool Lower Window Component. Please review it.

With this applied, I cannot move or resize floating windows.

    Attached is the modified patch. Please review it.  

That's better, but I am still able to un-dock the last panel, despite it looking like it tries to prevent me. See the attached movie. 

    We have figured out the actual cause of the problem, there is no title for the "SQL Editor" panel so when we undock lower window component then there is no title bar present to re-dock it. To fix the issue we have added the title for the "SQL Editor" panel and also move up the Query History tab. 

     Attached is the patch, please review it.      

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246