Thread: [pgAdmin4][Patch]: Fixed process watcher status message.
Hi Hackers,
Attached is the patch to show the correct message on the status bar of the process watcher when user has stopped the process.
--
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
Hi All
Please ignore my previous patch. Attached is the new modified patch.
On Wed, Oct 24, 2018 at 3:03 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,Attached is the patch to show the correct message on the status bar of the process watcher when user has stopped the process.--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
Hi Akshay,
The patch looks good to me. But, I would suggest using some dictionary or const variables for process states instead of hard code numbers 0,1,2,3. It would be more readable and easier to change.
On Wed, Oct 24, 2018 at 5:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AllPlease ignore my previous patch. Attached is the new modified patch.On Wed, Oct 24, 2018 at 3:03 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to show the correct message on the status bar of the process watcher when user has stopped the process.--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"