Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Fixed process watcher status message. - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin4][Patch]: Fixed process watcher status message.
Date
Msg-id CAM9w-_mEyKOZL1V9Jsn_BEu+daDEg2Ly3G+sYZpb_Yz+WJ9Z0A@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Fixed process watcher status message.  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Akshay,

The patch looks good to me. But, I would suggest using some dictionary or const variables for process states instead of hard code numbers 0,1,2,3. It would be more readable and easier to change.

On Wed, Oct 24, 2018 at 5:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All

Please ignore my previous patch. Attached is the new modified patch.

On Wed, Oct 24, 2018 at 3:03 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to show the correct message on the status bar of the process watcher when user has stopped the process.  

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch]: RM #3029 Cannot sort columns when importing data
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: 1) Fixed process watcher status message when userhas