Thread: [pgAdmin4][Patch]: Code refactoring
Hi,
PFA patch with some code refactoring.
--
Regards,
Attachment
+++
Below are the changes,
- Move the duplicate code for closing the background process dialog into 'test_gui_helper.py',
- Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'.
On Thu, Oct 4, 2018 at 9:35 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch with some code refactoring.--Regards,
Thanks, patch applied.
On Fri, Oct 5, 2018 at 7:56 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
+++Below are the changes,- Move the duplicate code for closing the background process dialog into 'test_gui_helper.py',- Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'.On Thu, Oct 4, 2018 at 9:35 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA patch with some code refactoring.--Regards,
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company