Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Code refactoring - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: Code refactoring
Date
Msg-id CA+OCxowdwfpyiwmq=J+DfT4H6i55bJwfySMnbJhtH=YpBQj2tg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Code refactoring  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Fri, Oct 5, 2018 at 7:56 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
+++ 

Below are the changes,
- Move the duplicate code for closing the background process dialog into 'test_gui_helper.py',
- Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'.


On Thu, Oct 4, 2018 at 9:35 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch with some code refactoring. 

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Code refactoring:
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions