Postgres Pro
Downloads
Home   >   mailing lists

Thread: Pithy patch for more detailed error reporting wheneffective_io_concurrency is set to nonzero on platforms lackingposix_fadvise()

Pithy patch for more detailed error reporting wheneffective_io_concurrency is set to nonzero on platforms lackingposix_fadvise()

From
James Robinson
Date:
Per Tom's suggestion on bug #15396, here's a patch to have platforms such as OSX give a more descriptive message when
rejectinga nonzero value for effective_io_concurrency. 

I had to adjust the GUC's wiring in the #ifndef case so that check_effective_io_concurrency() would be called when a
nonzerovalue is supplied instead of just short-circuiting in parse_and_validate_value() when outside of [conf->min,
conf->max].

James





-----
James Robinson
james@jlr-photo.com
http://jlr-photo.com/
Attachment

Re: Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()

From
Tom Lane
Date:
James Robinson <james@jlr-photo.com> writes:
> Per Tom's suggestion on bug #15396, here's a patch to have platforms such as OSX give a more descriptive message when
rejectinga nonzero value for effective_io_concurrency. 

Pushed with minor editorialization.

            regards, tom lane