Pithy patch for more detailed error reporting wheneffective_io_concurrency is set to nonzero on platforms lackingposix_fadvise() - Mailing list pgsql-hackers

From James Robinson
Subject Pithy patch for more detailed error reporting wheneffective_io_concurrency is set to nonzero on platforms lackingposix_fadvise()
Date
Msg-id A3942987-5BC7-4F05-B54D-2A0EC2914B33@jlr-photo.com
Whole thread Raw
Responses Re: Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()
List pgsql-hackers
Per Tom's suggestion on bug #15396, here's a patch to have platforms such as OSX give a more descriptive message when
rejectinga nonzero value for effective_io_concurrency. 

I had to adjust the GUC's wiring in the #ifndef case so that check_effective_io_concurrency() would be called when a
nonzerovalue is supplied instead of just short-circuiting in parse_and_validate_value() when outside of [conf->min,
conf->max].

James





-----
James Robinson
james@jlr-photo.com
http://jlr-photo.com/




Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Adding a note to protocol.sgml regarding CopyData
Next
From: Stephen Frost
Date:
Subject: Re: Use durable_unlink for .ready and .done files for WAL segmentremoval