Thread: pgsql: Restore erroneously removed ONLY from PK check

pgsql: Restore erroneously removed ONLY from PK check

From
Alvaro Herrera
Date:
Restore erroneously removed ONLY from PK check

This is a blind fix, since I don't have SE-Linux to verify it.

Per unwanted change in rhinoceros, running sepgsql tests.  Noted by Tom
Lane.

Discussion: https://postgr.es/m/32347.1522865050@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7d7c99790b2a7e6f4e5287a3fb29f73cedbb2105

Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


Re: pgsql: Restore erroneously removed ONLY from PK check

From
Andres Freund
Date:
On 2018-04-04 19:38:57 +0000, Alvaro Herrera wrote:
> Restore erroneously removed ONLY from PK check
> 
> This is a blind fix, since I don't have SE-Linux to verify it.
> 
> Per unwanted change in rhinoceros, running sepgsql tests.  Noted by Tom
> Lane.
> 
> Discussion: https://postgr.es/m/32347.1522865050@sss.pgh.pa.us
> 
> Branch
> ------
> master

Shouldn't the difference due to the ONLY be visible in cases with
inheritance?  As in, spuriously succeeding or such?  Seems like
something that a normal regression test would be good for?

Greetings,

Andres Freund


Re: pgsql: Restore erroneously removed ONLY from PK check

From
Tom Lane
Date:
Andres Freund <andres@anarazel.de> writes:
> Shouldn't the difference due to the ONLY be visible in cases with
> inheritance?  As in, spuriously succeeding or such?  Seems like
> something that a normal regression test would be good for?

Yeah, if it actually matters (which I think it does), it shouldn't be hard
to devise a regression test that shows a behavioral difference.

            regards, tom lane