Thread: pgAdmin 4 commit: Ignore config_local.py and config_distro.py whenrunn
Ignore config_local.py and config_distro.py when running PEP-8 checks. Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe Modified Files -------------- web/.pycodestyle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
I have just noticed, we're ignoring migrations directory too.
Should we not also check code styling for migrations directory?
On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:
Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a= commitdiff;h= 53ae960aeba0dde6109b91c171f227 58b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi
--
On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?
Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?
On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif f;h=53ae960aeba0dde6109b91c171 f22758b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.pywhen runn
From
Murtuza Zabuawala
Date:
HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?
To ease writing long SQL's.
On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif f;h=53ae960aeba0dde6109b91c171 f22758b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's.
Perhaps we could just skip the long line check for those files?
On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif f;h=53ae960aeba0dde6109b91c171 f22758b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.pywhen runn
From
Murtuza Zabuawala
Date:
Hi Dave,
On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <dpage@pgadmin.org> wrote:
On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's.Perhaps we could just skip the long line check for those files?
We have to create separate config for that and then run pycodestyle using that config for migration.
1) pycodestyle --config=.pycodestyle
2) pycodestyle --config=.pycodestyle_migration
something like that, Because I checked the documentation and I didn't find any option to have single config file for individual directories.
On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif f;h=53ae960aeba0dde6109b91c171 f22758b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's.Perhaps we could just skip the long line check for those files?We have to create separate config for that and then run pycodestyle using that config for migration.1) pycodestyle --config=.pycodestyle2) pycodestyle --config=.pycodestyle_migration something like that, Because I checked the documentation and I didn't find any option to have single config file for individual directories.
Urgh. I suppose we could keep a config file in the migration directory, but even then, we'll get two sets of stats out for running two tests.
On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif f;h=53ae960aeba0dde6109b91c171 f22758b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.pywhen runn
From
Joao De Almeida Pereira
Date:
Hello,
Personally I believe we should fix the config_local pep issues and just ignore the migrations. Specially because the migration file should not have a lot of python code.
Thanks
On Thu, Mar 15, 2018 at 3:32 PM Dave Page <dpage@pgadmin.org> wrote:
On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Dave,On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's.Perhaps we could just skip the long line check for those files?We have to create separate config for that and then run pycodestyle using that config for migration.1) pycodestyle --config=.pycodestyle2) pycodestyle --config=.pycodestyle_migrationsomething like that, Because I checked the documentation and I didn't find any option to have single config file for individual directories.Urgh. I suppose we could keep a config file in the migration directory, but even then, we'll get two sets of stats out for running two tests.On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Well config_local isn't part of the source tree, so it's easier to just ignore that. I'm happy with ignoring the migrations as well.
On Friday, March 16, 2018, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Friday, March 16, 2018, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello,Personally I believe we should fix the config_local pep issues and just ignore the migrations. Specially because the migration file should not have a lot of python code.ThanksOn Thu, Mar 15, 2018 at 3:32 PM Dave Page <dpage@pgadmin.org> wrote:On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Dave,On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's.Perhaps we could just skip the long line check for those files?We have to create separate config for that and then run pycodestyle using that config for migration.1) pycodestyle --config=.pycodestyle2) pycodestyle --config=.pycodestyle_migration something like that, Because I checked the documentation and I didn't find any option to have single config file for individual directories.Urgh. I suppose we could keep a config file in the migration directory, but even then, we'll get two sets of stats out for running two tests.On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a= commitdiff;h= 53ae960aeba0dde6109b91c171f227 58b1b04ebe
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company