Hi Dave,On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <dpage@pgadmin.org> wrote:On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's. Perhaps we could just skip the long line check for those files?We have to create separate config for that and then run pycodestyle using that config for migration. 1) pycodestyle --config=.pycodestyle2) pycodestyle --config=.pycodestyle_migrationsomething like that, Because I checked the documentation and I didn't find any option to have single config file for individual directories.
On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's. Perhaps we could just skip the long line check for those files?
On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?To ease writing long SQL's.
HiOn Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza?
Hi,I have just noticed, we're ignoring migrations directory too.Should we not also check code styling for migrations directory?
--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashiOn Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks. Branch ------ master Details -------https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe Modified Files -------------- web/.pycodestyle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company -- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashiOn Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks. Branch ------ master Details -------https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe Modified Files -------------- web/.pycodestyle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashiOn Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:Ignore config_local.py and config_distro.py when running PEP-8 checks. Branch ------ master Details -------https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe Modified Files -------------- web/.pycodestyle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--
Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Company
http://www.linkedin.com/in/asheshvashi
Ignore config_local.py and config_distro.py when running PEP-8 checks. Branch ------ master Details -------https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe Modified Files -------------- web/.pycodestyle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных
