Thread: Bug #2309 fix

Hi Neethu,

Patch looks good.

We are facing similar issue on dashboard as well where users are not able to copy the sql from server activity table, I've attached screenshot for your reference.

Bug: https://redmine.postgresql.org/issues/3137

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 2, 2018 at 3:35 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Neethu,

We run the patch though our test pipeline and all tests are green. Everything looks good with this patch

Thanks

Joao

On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:

Hi,

I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani.

I've attempted to fix https://redmine.postgresql.org/issues/2309. Codemirrors catches all the keyboard and mouse events when 'readOnly' option is set to 'noCursor' and does not allow copying.

So, I've set 'readOnly' option to true. In order to hide the cursor, I've added a class 'hide-cursor-workaround' and applied css styles to hide the cursor.

I'm attaching my patch as bug2309.diff below as per the contribution guidelines.

Hope this helps. Thank you for your consideration!

Sincerely,

Neethu Mariya Joy

GitHub | Linkedin

Hi,

A similar workaround fixed #3137 too. I'm attaching the patch below.

Sincerely,

Neethu

On Fri, Mar 2, 2018 at 9:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Neethu,

Patch looks good.

We are facing similar issue on dashboard as well where users are not able to copy the sql from server activity table, I've attached screenshot for your reference.

Bug: https://redmine.postgresql.org/issues/3137

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 2, 2018 at 3:35 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Neethu,

We run the patch though our test pipeline and all tests are green. Everything looks good with this patch

Thanks

Joao

On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:

Hi,

I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani.

I've attempted to fix https://redmine.postgresql.org/issues/2309. Codemirrors catches all the keyboard and mouse events when 'readOnly' option is set to 'noCursor' and does not allow copying.

So, I've set 'readOnly' option to true. In order to hide the cursor, I've added a class 'hide-cursor-workaround' and applied css styles to hide the cursor.

I'm attaching my patch as bug2309.diff below as per the contribution guidelines.

Hope this helps. Thank you for your consideration!

Sincerely,

Neethu Mariya Joy

GitHub | Linkedin