Re: Bug #2309 fix - Mailing list pgadmin-hackers

From Joao De Almeida Pereira
Subject Re: Bug #2309 fix
Date
Msg-id CAE+jjamYZfYvwqjonCsO_A5FNP-EuSzXNEdR8sk34hCNC3sUKA@mail.gmail.com
Whole thread Raw
In response to Bug #2309 fix  (Neethu Mariya Joy <neethumariyajoy@gmail.com>)
Responses Re: Bug #2309 fix
Re: Bug #2309 fix
List pgadmin-hackers
Hello Neethu,

We run the patch though our test pipeline and all tests are green. Everything looks good with this patch

Thanks
Joao
On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:
Hi,
I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani.

I've attempted to fix https://redmine.postgresql.org/issues/2309. Codemirrors catches all the keyboard and mouse events when 'readOnly' option is set to 'noCursor' and does not allow copying.
So, I've set 'readOnly' option to true. In order to hide the cursor, I've added a class 'hide-cursor-workaround' and applied css styles to hide the cursor.

I'm attaching my patch as bug2309.diff below as per the contribution guidelines.

Hope this helps. Thank you for your consideration!

Sincerely,
Neethu Mariya Joy

pgadmin-hackers by date:

Previous
From: Neethu Mariya Joy
Date:
Subject: Re: Feature #3061
Next
From: Joao De Almeida Pereira
Date:
Subject: Re: Bug #3083 fix