Thread: pgsql: Fix a couple of problems in pg_get_statisticsextdef
Fix a couple of problems in pg_get_statisticsextdef There was a thinko whereby we tested the wrong tuple after fetching it from cache; avoid that by using generate_relation_name instead, which is simpler. Also, the statistics name was not qualified, so add that. (It could be argued that qualification should be conditional on the schema not being on search path. We can add that later, but at least this form is correct.) Author: David Rowley, Álvaro Herrera Discussion: https://postgr.es/m/CAKJS1f8RjLeVZJ2+93pdQGuZJeBF-ifsHaFMR-q-6-Z0qxA8cA@mail.gmail.com Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/2c3e47527a6f53cd1d98887fdb9e770c118954ca Modified Files -------------- src/backend/utils/adt/ruleutils.c | 20 +++++--------------- src/test/regress/expected/rules.out | 6 ++++++ src/test/regress/expected/stats_ext.out | 7 +++++++ src/test/regress/sql/rules.sql | 1 + src/test/regress/sql/stats_ext.sql | 4 ++++ 5 files changed, 23 insertions(+), 15 deletions(-)
>>>>> "Alvaro" == Alvaro Herrera <alvherre@alvh.no-ip.org> writes: Alvaro> Fix a couple of problems in pg_get_statisticsextdef Alvaro> src/test/regress/expected/stats_ext.out | 7 +++++++ Missed an update to stats_ext_1.out ? -- Andrew (irc:RhodiumToad)
Andrew Gierth wrote: > >>>>> "Alvaro" == Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > > Alvaro> Fix a couple of problems in pg_get_statisticsextdef > > Alvaro> src/test/regress/expected/stats_ext.out | 7 +++++++ > > Missed an update to stats_ext_1.out ? Yeah ... instead of fixing it, I pushed Tomas's patch to remove the need for that file. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services