pgsql: Fix a couple of problems in pg_get_statisticsextdef - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Fix a couple of problems in pg_get_statisticsextdef
Date
Msg-id E1csLtZ-0002vy-LI@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix a couple of problems in pg_get_statisticsextdef
List pgsql-committers
Fix a couple of problems in pg_get_statisticsextdef

There was a thinko whereby we tested the wrong tuple after fetching it
from cache; avoid that by using generate_relation_name instead, which is
simpler.  Also, the statistics name was not qualified, so add that.  (It
could be argued that qualification should be conditional on the schema
not being on search path.  We can add that later, but at least this form
is correct.)

Author: David Rowley, Álvaro Herrera
Discussion: https://postgr.es/m/CAKJS1f8RjLeVZJ2+93pdQGuZJeBF-ifsHaFMR-q-6-Z0qxA8cA@mail.gmail.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2c3e47527a6f53cd1d98887fdb9e770c118954ca

Modified Files
--------------
src/backend/utils/adt/ruleutils.c       | 20 +++++---------------
src/test/regress/expected/rules.out     |  6 ++++++
src/test/regress/expected/stats_ext.out |  7 +++++++
src/test/regress/sql/rules.sql          |  1 +
src/test/regress/sql/stats_ext.sql      |  4 ++++
5 files changed, 23 insertions(+), 15 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Gierth
Date:
Subject: pgsql: Support hashed aggregation with grouping sets.
Next
From: Andrew Gierth
Date:
Subject: Re: pgsql: Support hashed aggregation with grouping sets.