Thread: Re: pgsql: Prohibit identity columns on typed tables and partitions
On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Prohibit identity columns on typed tables and partitions
>
> Those cases currently crash and supporting them is more work then
> originally thought, so we'll just prohibit these scenarios for now.
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("identify columns are not
supported on partitions")));
Er... s/identify/identity/. My fault I guess.
--
Michael
Attachment
On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
-- On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Prohibit identity columns on typed tables and partitions
>
> Those cases currently crash and supporting them is more work then
> originally thought, so we'll just prohibit these scenarios for now.
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("identify columns are not
supported on partitions")));
Er... s/identify/identity/. My fault I guess.
Spotted the separate report on it first, so a fix has been pushed.
On 12/9/17 05:47, Magnus Hagander wrote:
>
>
> On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier
> <michael.paquier@gmail.com <mailto:michael.paquier@gmail.com>> wrote:
>
> On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net
> <mailto:peter_e@gmx.net>> wrote:
> > Prohibit identity columns on typed tables and partitions
> >
> > Those cases currently crash and supporting them is more work then
> > originally thought, so we'll just prohibit these scenarios for now.
>
> + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> + errmsg("identify columns are not
> supported on partitions")));
> Er... s/identify/identity/. My fault I guess.
>
>
> Spotted the separate report on it first, so a fix has been pushed.
Please also backpatch to PG10.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Sat, Dec 9, 2017 at 10:45 PM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
-- On 12/9/17 05:47, Magnus Hagander wrote:
>
>
> On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier
> <michael.paquier@gmail.com <mailto:michael.paquier@gmail.com>> wrote:
>
> On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net
> <mailto:peter_e@gmx.net>> wrote:
> > Prohibit identity columns on typed tables and partitions
> >
> > Those cases currently crash and supporting them is more work then
> > originally thought, so we'll just prohibit these scenarios for now.
>
> + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> + errmsg("identify columns are not
> supported on partitions")));
> Er... s/identify/identity/. My fault I guess.
>
>
> Spotted the separate report on it first, so a fix has been pushed.
Please also backpatch to PG10.
Oops, I completely missed that the original patch was backpatched. Will fix, thanks!