Thread: [pgcommitfest2] Sorting columns
Hi all,
Currently on the patches page the table is sorted on the patch column by default. Latest activity/mail columns are also sortable but no one knows until hovering the column headers. And even when sorting by a column other than patch no arrow is displayed to show the current sorting.
Please find attached 2 patches respectively to fix and enhance the columns sorting for the patches table.
The attached image shows the result.
Cheers,
Pierre
Attachment
Hi all,
Currently on the patches page the table is sorted on the patch column by default. Latest activity/mail columns are also sortable but no one knows until hovering the column headers. And even when sorting by a column other than patch no arrow is displayed to show the current sorting.
Please find attached 2 patches respectively to fix and enhance the columns sorting for the patches table.
The attached image shows the result.
On Thu, Nov 23, 2017 at 5:01 PM, Pierre Giraud <pierre.giraud@dalibo.com> wrote:Hi all,
Currently on the patches page the table is sorted on the patch column by default. Latest activity/mail columns are also sortable but no one knows until hovering the column headers. And even when sorting by a column other than patch no arrow is displayed to show the current sorting.
Please find attached 2 patches respectively to fix and enhance the columns sorting for the patches table.
The attached image shows the result.
Hi!Apologies for a very late response to this one. I put it aside for "answer quickly", and then promptly forgot.I agree that the current indication of what's sortable is quite bad. But I don't think the new one is that much better -- we should have something much more clear than just "different amount of gray", I think.
--
2018-01-02 21:33 GMT+01:00 Magnus Hagander <magnus@hagander.net>:On Thu, Nov 23, 2017 at 5:01 PM, Pierre Giraud <pierre.giraud@dalibo.com> wrote:Hi all,
Currently on the patches page the table is sorted on the patch column by default. Latest activity/mail columns are also sortable but no one knows until hovering the column headers. And even when sorting by a column other than patch no arrow is displayed to show the current sorting.
Please find attached 2 patches respectively to fix and enhance the columns sorting for the patches table.
The attached image shows the result.
Hi!Apologies for a very late response to this one. I put it aside for "answer quickly", and then promptly forgot.I agree that the current indication of what's sortable is quite bad. But I don't think the new one is that much better -- we should have something much more clear than just "different amount of gray", I think.I disagree, it looks much better than now with a really small patch.
On Sat, Jan 20, 2018 at 5:21 AM, Magnus Hagander <magnus@hagander.net> wrote: > Does anybody else have an opinion of this? Doesn't this kind of thing generally happen using Javascript, rather than by doing an http request to the server? For example: https://www.learningjquery.com/2017/03/how-to-sort-html-table-using-jquery-code (The only reason that I know this is because pgbench-tools used jQuery...I am pretty clueless when it comes to front end web development.) -- Peter Geoghegan
On Sat, Jan 20, 2018 at 5:21 AM, Magnus Hagander <magnus@hagander.net> wrote:
> Does anybody else have an opinion of this?
Doesn't this kind of thing generally happen using Javascript, rather
than by doing an http request to the server? For example:
https://www.learningjquery.com/2017/03/how-to-sort-html- table-using-jquery-code
(The only reason that I know this is because pgbench-tools used
jQuery...I am pretty clueless when it comes to front end web
development.)
On Sat, Jan 20, 2018 at 03:21:49PM +0200, Magnus Hagander wrote: > On Wed, Jan 3, 2018 at 11:00 AM, Guillaume Lelarge <guillaume@lelarge.info> > wrote: > > I disagree, it looks much better than now with a really small patch. > > Does anybody else have an opinion of this? How about making them all sortable and avoiding this UX issue entirely? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
On Sat, Jan 20, 2018 at 2:23 PM, Magnus Hagander <magnus@hagander.net> wrote: > Sure, it can be done that way as well. But the patch isn't really about > that, it's about what it *looks* like. There is no change at all to > functionality. I understand that, but I think it's fair to say that what it looks like is influenced by whether or not it happens client-side. And I think it's also fair to say that there might be an opportunity to kill two birds with one stone. It's not as if I feel very strongly about it, though. -- Peter Geoghegan