Thread: Remove !isTemp buffile.c code

Hi,

A nearby thread [1], does some work on buffile.c.  Amongst others it
renames isTemp to something else (not sure yet why - the new name is
about as apt as before), but that's not really what I want to talk about
here.

buffile.c currently has a fair amount of code dependant on
BufFile->isTemp - which afaics hasn't ever been used.  I'd rather remove
that code, before potentially (further) breaking the unused code.

Any arguments against?

Greetings,

Andres Freund

[1] https://www.postgresql.org/message-id/CAEepm=0vp18JyWa5o_=ehK1QTZrymXk3Q0NPJoSqb=tdQTifGw@mail.gmail.com

On Sat, Mar 25, 2017 at 10:25 PM, Andres Freund <andres@anarazel.de> wrote:
> buffile.c currently has a fair amount of code dependant on
> BufFile->isTemp - which afaics hasn't ever been used.  I'd rather remove
> that code, before potentially (further) breaking the unused code.

I think this is a good idea, but then I suggested it originally.


-- 
Peter Geoghegan