Remove !isTemp buffile.c code - Mailing list pgsql-hackers

From Andres Freund
Subject Remove !isTemp buffile.c code
Date
Msg-id 20170326052516.rxqw3cxks35qmchk@alap3.anarazel.de
Whole thread Raw
Responses Re: Remove !isTemp buffile.c code  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Hi,

A nearby thread [1], does some work on buffile.c.  Amongst others it
renames isTemp to something else (not sure yet why - the new name is
about as apt as before), but that's not really what I want to talk about
here.

buffile.c currently has a fair amount of code dependant on
BufFile->isTemp - which afaics hasn't ever been used.  I'd rather remove
that code, before potentially (further) breaking the unused code.

Any arguments against?

Greetings,

Andres Freund

[1] https://www.postgresql.org/message-id/CAEepm=0vp18JyWa5o_=ehK1QTZrymXk3Q0NPJoSqb=tdQTifGw@mail.gmail.com



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Faster expression evaluationand targetlist projection.
Next
From: Peter Geoghegan
Date:
Subject: Re: Remove !isTemp buffile.c code