Thread: Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlistprojection.

On 03/25/2017 04:03 PM, Andres Freund wrote:
> Hi Joe,
>
>
> On 2017-03-25 22:11:37 +0000, Andres Freund wrote:
>> Faster expression evaluation and targetlist projection.
>
> Apparently this broke the selinux integration somehow:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2017-03-25%2022%3A45%3A01
>
> Unfortunately the buildfarm appears to not display regression.diffs -
> making this a bit hard to debug remotely.  Any chance you could help me
> out with that? I'd rather not setup selinux here...


Sure. What exactly do you want? Should we jump on a call or hangout or
something?

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

On 2017-03-25 16:36:03 -0700, Joe Conway wrote:
> On 03/25/2017 04:03 PM, Andres Freund wrote:
> > Hi Joe,
> > 
> > 
> > On 2017-03-25 22:11:37 +0000, Andres Freund wrote:
> >> Faster expression evaluation and targetlist projection.
> > 
> > Apparently this broke the selinux integration somehow:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2017-03-25%2022%3A45%3A01
> > 
> > Unfortunately the buildfarm appears to not display regression.diffs -
> > making this a bit hard to debug remotely.  Any chance you could help me
> > out with that? I'd rather not setup selinux here...
> 
> 
> Sure. What exactly do you want?

I think, for starters, seeing regression.diffs from sepgsql would be
useful.  Might already clear up what's the issue.


> Should we jump on a call or hangout or something?

I think for now just seeing regression.diffs would be enough - depending
on what the differences are. Could very well be that we're just seing a
difference due to function permission checks happening a bit earlier
now.

Greetings,

Andres Freund

On 03/25/2017 04:45 PM, Andres Freund wrote:
> On 2017-03-25 16:36:03 -0700, Joe Conway wrote:
>> On 03/25/2017 04:03 PM, Andres Freund wrote:
>> > Hi Joe,
>> >
>> >
>> > On 2017-03-25 22:11:37 +0000, Andres Freund wrote:
>> >> Faster expression evaluation and targetlist projection.
>> >
>> > Apparently this broke the selinux integration somehow:
>> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2017-03-25%2022%3A45%3A01
>> >
>> > Unfortunately the buildfarm appears to not display regression.diffs -
>> > making this a bit hard to debug remotely.  Any chance you could help me
>> > out with that? I'd rather not setup selinux here...
>>
>>
>> Sure. What exactly do you want?
>
> I think, for starters, seeing regression.diffs from sepgsql would be
> useful.  Might already clear up what's the issue.

I went looking, and even after a forced run the diff file is gone --
does the buildfarm auto-cleanup or something?

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

On March 25, 2017 4:54:08 PM PDT, Joe Conway <mail@joeconway.com> wrote:
>On 03/25/2017 04:45 PM, Andres Freund wrote:
>> On 2017-03-25 16:36:03 -0700, Joe Conway wrote:
>>> On 03/25/2017 04:03 PM, Andres Freund wrote:
>>> > Hi Joe,
>>> >
>>> >
>>> > On 2017-03-25 22:11:37 +0000, Andres Freund wrote:
>>> >> Faster expression evaluation and targetlist projection.
>>> >
>>> > Apparently this broke the selinux integration somehow:
>>> >
>https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2017-03-25%2022%3A45%3A01
>>> >
>>> > Unfortunately the buildfarm appears to not display
>regression.diffs -
>>> > making this a bit hard to debug remotely.  Any chance you could
>help me
>>> > out with that? I'd rather not setup selinux here...
>>>
>>>
>>> Sure. What exactly do you want?
>>
>> I think, for starters, seeing regression.diffs from sepgsql would be
>> useful.  Might already clear up what's the issue.
>
>I went looking, and even after a forced run the diff file is gone --
>does the buildfarm auto-cleanup or something?

Yes, it does. You'd probably have to run the tests manually.  Do you have selinux setup?  I assumed you would, given I
seento recall a talk of yours with references to it ;) 
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

On 03/25/2017 05:21 PM, Andres Freund wrote:
> On March 25, 2017 4:54:08 PM PDT, Joe Conway <mail@joeconway.com> wrote:
>>On 03/25/2017 04:45 PM, Andres Freund wrote:
>>> I think, for starters, seeing regression.diffs from sepgsql would be
>>> useful.  Might already clear up what's the issue.
>>
>>I went looking, and even after a forced run the diff file is gone --
>>does the buildfarm auto-cleanup or something?
>
> Yes, it does. You'd probably have to run the tests manually.  Do you
> have selinux setup?  I assumed you would, given I seen to recall a
> talk of yours with references to it ;)


Yeah, but those machines are MLS fully constrained, and the sepgsql
regression test specifically needs "targeted" and some other particular
setup. So the easiest box to run this on is the buildfarm animal, but I
also want to do it in a way that doesn't mess up that environment.

I found "keep_error_builds" in build-farm.conf and tried setting to 1
and rerunning in force -- that seems to have worked, so diffs attached.

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

Hi,

On 2017-03-25 17:33:33 -0700, Joe Conway wrote:
> On 03/25/2017 05:21 PM, Andres Freund wrote:
> > On March 25, 2017 4:54:08 PM PDT, Joe Conway <mail@joeconway.com> wrote:
> >>On 03/25/2017 04:45 PM, Andres Freund wrote:
> >>> I think, for starters, seeing regression.diffs from sepgsql would be
> >>> useful.  Might already clear up what's the issue.
> >>
> >>I went looking, and even after a forced run the diff file is gone --
> >>does the buildfarm auto-cleanup or something?
> > 
> > Yes, it does. You'd probably have to run the tests manually.  Do you
> > have selinux setup?  I assumed you would, given I seen to recall a
> > talk of yours with references to it ;)

> Yeah, but those machines are MLS fully constrained, and the sepgsql
> regression test specifically needs "targeted" and some other particular
> setup. So the easiest box to run this on is the buildfarm animal, but I
> also want to do it in a way that doesn't mess up that environment.

Ah.


> I found "keep_error_builds" in build-farm.conf and tried setting to 1
> and rerunning in force -- that seems to have worked, so diffs attached.

Thanks. Those all look like "valid" differences, i.e. checks that
previously hadn't been executed because the function is never invoked,
as there's no data in those tables.

I blindly tried to fix these, let's hope that works.

- Andres

On 2017-03-25 20:40:23 -0700, Andres Freund wrote:
> I blindly tried to fix these, let's hope that works.

In a second attempt (yes, reading diffs correctly is helpful), this
resolved the selinux issue. Yeha.

- Andres

On 03/25/2017 09:52 PM, Andres Freund wrote:
> On 2017-03-25 20:40:23 -0700, Andres Freund wrote:
>> I blindly tried to fix these, let's hope that works.
>
> In a second attempt (yes, reading diffs correctly is helpful), this
> resolved the selinux issue. Yeha.

+1!

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development