Thread: Donation links on about/donate

Spotted some strange links on about/donate.  The PgUS link was seemingly
leading to the incorrect page altogether (pgeu content) and the PgEU link was
missing https causing a redirect.  Fixed in the attached patch by instead
linking to what seems to be the actual donations page for PgUS.

Also lowercased the urls to make code grepping a little easier.

cheers ./daniel

Daniel,

* Daniel Gustafsson (daniel@yesql.se) wrote:
> Spotted some strange links on about/donate.  The PgUS link was seemingly
> leading to the incorrect page altogether (pgeu content) and the PgEU link was
> missing https causing a redirect.  Fixed in the attached patch by instead
> linking to what seems to be the actual donations page for PgUS.

Whoops, will take a look into this, I suspect we might just need to fix
things on the PgUS side.

> Also lowercased the urls to make code grepping a little easier.

That seems reasonable.  Will take a look shortly and see about fixing
things.

Thanks!

Stephen

Daniel,

* Daniel Gustafsson (daniel@yesql.se) wrote:
> Spotted some strange links on about/donate.  The PgUS link was seemingly
> leading to the incorrect page altogether (pgeu content) and the PgEU link was
> missing https causing a redirect.  Fixed in the attached patch by instead
> linking to what seems to be the actual donations page for PgUS.

I've fixed the /donate link on the PgUS page, so we can continue to have
the link go there (as there might be other places too, this seemed to
make the most sense to me).

> Also lowercased the urls to make code grepping a little easier.

I'll push these changes soon, unless anyone would like to object.

Thanks!

Stephen

> On 04 Apr 2017, at 17:27, Stephen Frost <sfrost@snowman.net> wrote:
>
> * Daniel Gustafsson (daniel@yesql.se) wrote:
>> Spotted some strange links on about/donate.  The PgUS link was seemingly
>> leading to the incorrect page altogether (pgeu content) and the PgEU link was
>> missing https causing a redirect.  Fixed in the attached patch by instead
>> linking to what seems to be the actual donations page for PgUS.
>
> I've fixed the /donate link on the PgUS page, so we can continue to have
> the link go there (as there might be other places too, this seemed to
> make the most sense to me).

Even better!

>> Also lowercased the urls to make code grepping a little easier.
>
> I'll push these changes soon, unless anyone would like to object.

That, and going to https to avoid a redirect, still makes sense to me.

cheers ./daniel