Thread: [COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.
[COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.
From
Robert Haas
Date:
Avoid coercing a whole-row variable that is already coerced. Marginal efficiency and beautification hack. I'm not sure whether this case ever arises currently, but the pending patch for update tuple routing will cause it to arise. Amit Khandekar Discussion: http://postgr.es/m/CAJ3gD9cazfppe7-wwUbabPcQ4_0SubkiPFD1+0r5_DkVNWo5yg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1c497fa72df7593d8976653538da3d0ab033207f Modified Files -------------- src/backend/rewrite/rewriteManip.c | 53 ++++++++++++++++++++++++++++++-------- 1 file changed, 42 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.
From
Tom Lane
Date:
Robert Haas <rhaas@postgresql.org> writes:
> Avoid coercing a whole-row variable that is already coerced.
This logic seems very strange and more than likely buggy: the
added coerced_var flag feels like the sort of action at a distance
that is likely to have unforeseen side effects.
I'm not entirely sure what the issue is here, but if you're concerned
about not applying two ConvertRowtypeExprs in a row, why not have the
upper one just strip off the lower one? We handle, eg, nested
RelabelTypes that way.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers