Re: [COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced. - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.
Date
Msg-id 1579.1507844521@sss.pgh.pa.us
Whole thread Raw
In response to [COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.  (Robert Haas <rhaas@postgresql.org>)
List pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
> Avoid coercing a whole-row variable that is already coerced.

This logic seems very strange and more than likely buggy: the
added coerced_var flag feels like the sort of action at a distance
that is likely to have unforeseen side effects.

I'm not entirely sure what the issue is here, but if you're concerned
about not applying two ConvertRowtypeExprs in a row, why not have the
upper one just strip off the lower one?  We handle, eg, nested
RelabelTypes that way.
        regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.
Next
From: Peter Geoghegan
Date:
Subject: Re: [COMMITTERS] pgsql: Fix traversal of half-frozen update chains