Thread: [gpAdmin4][patch] query history updates

Hi Hackers,

Here is a patch for query tools history UX improvements:

• Add copy button for query text
  
• Historical queries are binned by day
  

Thanks,

Sarah & Hao

Hi Khushboo,

     Thanks for your review. 

     About the copy/paste function bug, we just found that this is an existing bug in master. Except for the query History tab, this bug also exist in the query data output . If you copy the data row in "Data Output" tab,  it works fine, but the copy/paste in query tool won't work either. We will create a Redmine bug later.

     And the feature test failure, we've already sent a new patch that fixed it. See this patch

Thanks,

Wenlin & Violet

On Mon, Aug 7, 2017 at 1:45 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi Sarah & Hao,

The copy/paste functionality through the added copy button is working fine, however once I copy the query text from the History tab through the copy button, I can not perform copy/paste for some another text in the Query tool.

Also, the feature test (QueryToolJourneyTest) is failing, please refer the attached screen-shot.

Thanks,

Khushboo

On Thu, Aug 3, 2017 at 9:03 AM, Hao Wang <haowang@pivotal.io> wrote:

Hi Hackers,

Here is a patch for query tools history UX improvements:

• Add copy button for query text
  
• Historical queries are binned by day
  

Thanks,

Sarah & Hao

Hi,

The patch looks good to me.

The feature test for the QueryToolJourneyTest still fails on my Ubuntu machine with/without this patch, but works on Mac.

Thanks,

Khushboo

On Wed, Aug 9, 2017 at 9:07 AM, Sarah McAlear <smcalear@pivotal.io> wrote:

Hi Khushboo!

These are 2 separate patches. The failure of the feature test you're describing happens on Master even without this patch. The other patch fixes this, but is unrelated to this patch. Right now it applies cleanly on Master. If we rebase it here, we won't be able to apply it on master. 

Thanks,
Sarah

On Tue, Aug 8, 2017 at 6:27 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi Wenlin & Violet,

On Tue, Aug 8, 2017 at 12:05 PM, Wenlin Zhang <wzhang@pivotal.io> wrote:

Hi Khushboo,

     Thanks for your review. 

     About the copy/paste function bug, we just found that this is an existing bug in master. Except for the query History tab, this bug also exist in the query data output . If you copy the data row in "Data Output" tab,  it works fine, but the copy/paste in query tool won't work either. We will create a Redmine bug later.

     And the feature test failure, we've already sent a new patch that fixed it. See this patch

I need to test this patch with the history tab update patch. Right now I can not apply this patch on top of the history update patch.

Can you please re-base that patch? 

Thanks,

Wenlin & Violet

On Mon, Aug 7, 2017 at 1:45 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi Sarah & Hao,

The copy/paste functionality through the added copy button is working fine, however once I copy the query text from the History tab through the copy button, I can not perform copy/paste for some another text in the Query tool.

Also, the feature test (QueryToolJourneyTest) is failing, please refer the attached screen-shot.

Thanks,

Khushboo

On Thu, Aug 3, 2017 at 9:03 AM, Hao Wang <haowang@pivotal.io> wrote:

Hi Hackers,

Here is a patch for query tools history UX improvements:

• Add copy button for query text
  
• Historical queries are binned by day
  

Thanks,

Sarah & Hao

Thanks,

Khushboo