Thread: [pgAdmin4][Patch][RM_2567] : Default privileges don't show onProperties tab for database.
Attachment
Murtuza,
Please review this one.
On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:
Hi,PFA patch that fixes Default privileges don't show on Properties tab for databaseThanks,Atul
Hi Atul,
The given patch breaks RM#1801.
After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False.
--
Regards,
On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Murtuza,Please review this one.On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:Hi,PFA patch that fixes Default privileges don't show on Properties tab for databaseThanks,Atul
ok, Lemme check and I will get back to you.
Thanks,
Atul
On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Atul,The given patch breaks RM#1801.After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False.--Regards,On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Murtuza,Please review this one.On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:Hi,PFA patch that fixes Default privileges don't show on Properties tab for databaseThanks,Atul
Hi Atul,
Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator.
--
Regards,
On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:
ok, Lemme check and I will get back to you.Thanks,AtulOn Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Atul,The given patch breaks RM#1801.After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False.--Regards,On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Murtuza,Please review this one.On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:Hi,PFA patch that fixes Default privileges don't show on Properties tab for databaseThanks,Atul
makes sense. Thanks for the solution.
Please find attached revised patch.
Thanks,
Atul
On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Atul,Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator.--Regards,On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:ok, Lemme check and I will get back to you.Thanks,AtulOn Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Atul,The given patch breaks RM#1801.After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False.--Regards,On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Murtuza,Please review this one.On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:Hi,PFA patch that fixes Default privileges don't show on Properties tab for databaseThanks,Atul
Attachment
Patch looks good to me.
--
Regards,
On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:
makes sense. Thanks for the solution.Please find attached revised patch.Thanks,AtulOn Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Atul,Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator.--Regards,On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:ok, Lemme check and I will get back to you.Thanks,AtulOn Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Atul,The given patch breaks RM#1801.After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False.--Regards,On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Murtuza,Please review this one.On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:Hi,PFA patch that fixes Default privileges don't show on Properties tab for databaseThanks,Atul
On Tue, Aug 8, 2017 at 3:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Patch looks good to me.--Regards,On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:makes sense. Thanks for the solution.Please find attached revised patch.
Committed with minor change in existing logic.
Thanks,AtulOn Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Atul,Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator.--Regards,On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:ok, Lemme check and I will get back to you.Thanks,AtulOn Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Atul,The given patch breaks RM#1801.After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False.--Regards,On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Murtuza,Please review this one.On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <atul.sharma@enterprisedb.com> wrote:Hi,PFA patch that fixes Default privileges don't show on Properties tab for databaseThanks,Atul